Skip to content

Conversation

@lisajulia
Copy link
Contributor

@lisajulia lisajulia commented Sep 4, 2025

Look at it here:
https://github.com/cap-java/cds-feature-attachments/tree/rework-documentation

Changes:

@lisajulia lisajulia force-pushed the rework-documentation branch 3 times, most recently from 7d3fe56 to 74dc59a Compare September 4, 2025 13:45
@lisajulia lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia lisajulia marked this pull request as draft September 4, 2025 13:45
@lisajulia lisajulia force-pushed the rework-documentation branch from 74dc59a to 9da5a45 Compare September 4, 2025 13:46
@lisajulia lisajulia force-pushed the rework-documentation branch from 9da5a45 to 950a666 Compare September 4, 2025 14:38
Copy link

@maxieckert-sap maxieckert-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more general remark:

  • the documentation uses both, the bookshop sample, as well as the incidents sample app -> let's try to streamline it and use a common sample throughout the docs (i.e. incidents)

@lisajulia
Copy link
Contributor Author

In capire we would avoid using e.g. and i.e. but I didn't change it here. I'll leave it up to you to replace these with "for example" or "that is" or not.

I've replaced these. Thanks!

@lisajulia
Copy link
Contributor Author

@renejeglinsky, @eric-pSAP, @maxieckert-sap, @mofterdinger: Can you have yet another look? Thanks!

@lisajulia lisajulia force-pushed the rework-documentation branch 2 times, most recently from 60f6b1f to ba5007c Compare September 9, 2025 14:03
@lisajulia lisajulia force-pushed the rework-documentation branch from ba5007c to be23fff Compare September 9, 2025 14:06
@lisajulia lisajulia marked this pull request as ready for review September 9, 2025 14:09
Copy link
Contributor

@renejeglinsky renejeglinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@lisajulia lisajulia merged commit ce08b97 into main Sep 9, 2025
4 checks passed
@lisajulia lisajulia deleted the rework-documentation branch September 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants