Skip to content

Fixed deployment of snapshot to artifactory #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025
Merged

Fixed deployment of snapshot to artifactory #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17e9e07
added profile deploy-release
mofterdinger Jun 6, 2025
c377361
just cosmetics
mofterdinger Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ runs:
distribution: sapmachine
cache: maven

- name: Setup Maven ${{ inputs.maven-version }}
- name: Set up Maven ${{ inputs.maven-version }}
uses: stCarolas/setup-maven@v5
with:
maven-version: ${{ inputs.maven-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/deploy-release/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ runs:
-Dmaven.test.skip=true
-Dgpg.passphrase="$GPG_PASSPHRASE"
-Dgpg.keyname="$GPG_PUB_KEY"
clean deploy
clean deploy -P deploy-release
shell: bash
env:
MAVEN_CENTRAL_USER: ${{ inputs.user }}
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/newrelease/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ runs:
distribution: sapmachine
cache: maven

- name: Setup Maven ${{ inputs.maven-version }}
- name: Set up Maven ${{ inputs.maven-version }}
uses: stCarolas/setup-maven@v5
with:
maven-version: ${{ inputs.maven-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/scan-with-blackduck/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ runs:
distribution: sapmachine
cache: maven

- name: Setup Maven ${{ inputs.maven-version }}
- name: Set up Maven ${{ inputs.maven-version }}
uses: stCarolas/setup-maven@v5
with:
maven-version: ${{ inputs.maven-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build:
name: Build
name: Build and Sonar Scan
runs-on: ubuntu-latest
strategy:
matrix:
Expand Down
63 changes: 36 additions & 27 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,32 +236,6 @@
</execution>
</executions>
</plugin>

<plugin>
<artifactId>maven-gpg-plugin</artifactId>
<executions>
<execution>
<id>sign-artifacts</id>
<phase>deploy</phase>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<configuration>
<publishingServerId>central</publishingServerId>
<excludeArtifacts>
<excludeArtifact>cds-feature-attachments-integration-tests-parent</excludeArtifact>
<excludeArtifact>cds-feature-attachments-integration-tests-db</excludeArtifact>
<excludeArtifact>cds-feature-attachments-integration-tests-srv</excludeArtifact>
</excludeArtifacts>
</configuration>
</plugin>
</plugins>

<pluginManagement>
Expand Down Expand Up @@ -337,6 +311,41 @@
</pluginManagement>
</build>

<profiles>
<profile>
<id>deploy-release</id>
<build>
<plugins>
<plugin>
<artifactId>maven-gpg-plugin</artifactId>
<executions>
<execution>
<id>sign-artifacts</id>
<phase>deploy</phase>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.sonatype.central</groupId>
<artifactId>central-publishing-maven-plugin</artifactId>
<configuration>
<publishingServerId>central</publishingServerId>
<excludeArtifacts>
<excludeArtifact>cds-feature-attachments-integration-tests-parent</excludeArtifact>
<excludeArtifact>cds-feature-attachments-integration-tests-db</excludeArtifact>
<excludeArtifact>cds-feature-attachments-integration-tests-srv</excludeArtifact>
</excludeArtifacts>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<distributionManagement>
<snapshotRepository>
<id>artifactory</id>
Expand All @@ -356,4 +365,4 @@
<developerConnection>scm:git:[email protected]:cap-java/cds-feature-attachments.git</developerConnection>
</scm>

</project>
</project>