Skip to content

Removed interface ActiveEntityModifierProvider #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 1, 2025
Merged

Removed interface ActiveEntityModifierProvider #419

merged 10 commits into from
Apr 1, 2025

Conversation

@mofterdinger
Copy link
Collaborator

@mofterdinger mofterdinger commented Mar 26, 2025 •
edited
Loading

  • Removed interface ActiveEntityModifierProvider and adapt consumers.
  • Directly create instances of ActiveEntityModifier without a provider.
  • Adjusted some test cases.

agoerler
agoerler approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@agoerler agoerler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofterdinger mofterdinger enabled auto-merge (squash) April 1, 2025 16:20
@mofterdinger mofterdinger merged commit c0d90fb into main Apr 1, 2025
1 check passed
@mofterdinger mofterdinger deleted the remove_provider branch April 1, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agoerler agoerler agoerler approved these changes

@BraunMatthias BraunMatthias Awaiting requested review from BraunMatthias

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mofterdinger @agoerler