Skip to content

Add annotation @Core.ContentDisposition to get fileName on creation #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add annotation @Core.ContentDisposition to get fileName on creation #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ts/src/main/resources/cds/com.sap.cds/cds-feature-attachments/attachments-annotations.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ annotate Attachments with @UI: {
{Value: note}
]
} {
content @Core.ContentDisposition: { Filename: fileName, Type: 'inline' };
Copy link
Collaborator

@adamandre79 adamandre79 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist da nicht das gleiche wie in:

cds-feature-attachments/cds-feature-attachments/src/main/resources/cds/com.sap.cds/cds-feature-attachments/attachments-annotations.cds

Line 10 in a581f32

ContentDisposition.Filename: fileName,

Copy link
Collaborator Author

@mofterdinger mofterdinger Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, das hatte ich ganz uebersehen. Es hatte bisher aber nicht funktioniert, der fileName wurde nicht uebertragen. Mit dieser Annotation hat es dann geklappt. Die SDM Kollegen haben danach gefragt.

Copy link
Collaborator

@adamandre79 adamandre79 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dann kann man es vielleicht an der anderen Stelle löschen, aber wenn es so funktioniert, dann approve ich mal

Copy link
Collaborator Author

@mofterdinger mofterdinger Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wie ist das mit Annotations bei Aspekten, werden die auch vererbt ? Bisher war diese Annotation beim Aspect MediaData. Hatte das frueher schon mal funktioniert ?

Copy link
Collaborator

@adamandre79 adamandre79 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich dachte sie werden vererbt, aber wenn das nicht richtig funktioniert, dann sollten wir alle an den Attachment-Aspect packen, was denkst du?

Copy link
Collaborator Author

@mofterdinger mofterdinger Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scheint ein Bug oder Feature im cds compiler zu sein. Nur wenn ich die Anntation nochmal am Attachment Aspekt mache, bekomme ich die Annotations auch im EDMX zu sehen:

      <Annotations Target="AdminService.Books_covers/content">
        <Annotation Term="Core.ContentDisposition">
          <Record Type="Core.ContentDispositionType">
            <PropertyValue Property="Filename" Path="fileName"/>
            <PropertyValue Property="Type" String="inline"/>
          </Record>
        </Annotation>
        <Annotation Term="Core.MediaType" Path="mimeType"/>
        <Annotation Term="Common.Label" String="{i18n>attachment_content}"/>
      </Annotations>

Das EDMX ist allerdings relevant fuer das Fiori UI.

Ich merge deswegen diesen PR und lasse die Annotation auch am MediaData Aspekt stehen.

note @(title: '{i18n>attachment_note}');
modifiedAt @(odata.etag);
}
Expand Down