Mod is incompatible with other mods that add timestamps

[70CentsApple]

Some mods (e.g. Tweakeroo, Chat Tools etc.) adds a timestamp in front of the messages, however it doesn't work very well with Compact Chat. Also, I found a former issue that is similar to my problem that is #21.

I can give you a RegEx that can matches Timestamps like [12:34:56] or [12:34], that is \[?\d{1,2}:\d{2}(:\d{2})*\]? * .

[caoimhebyrne]

I'll take a look at this again. Thanks for the report!

[caoimhebyrne]

TL;DR: I have to look into this a bit more to see if I can find a nice solution. Sorry about the delay on this!

Tweakeroo does a bit of manipulation on the text (a lot more than I'd like them to), which makes it quite hard to compare the text when removing the timestamps.

The main issue with that is, our mixin runs before Tweakeroo's (probably due to the name of our mixin ChatHudMixin vs theirs MixinChatHud), so the message that we first get (to append the occurrences count) doesn't contain the timestamp. The only time we see a message with a timestamp is when we go to remove old occurrences of the message. This is fine, but again, not ideal, as they modify the hierarchy of the message a bit, making it hard to see if the messages are equal after removing the timestamp.

A Text component in Minecraft comes in many forms, and can have many different properties.

A message, modified by Tweakeroo, with the timestamp stripped by Compact Chat

A normal chat message

Yes, I've tried just comparing them with a getString, that brings suboptimal results.

[caoimhebyrne]

Hey! Sorry about the delay on this, I'm hopefully going to get back to this soon @70CentsApple.

[70CentsApple]

no matter, you can finish it whenever you like :)

[caoimhebyrne]

I've made an upstream patch to Tweakeroo to help add support for CompactChat, it will also need changes on my side. If there's any other mods that you're aware of, can you make sure they follow similar functionality to what I've demonstrated in my patch?

maruohon/tweakeroo#447

[70CentsApple]

I've made an upstream patch to Tweakeroo to help add support for CompactChat, it will also need changes on my side. If there's any other mods that you're aware of, can you make sure they follow similar functionality to what I've demonstrated in my patch?

maruohon/tweakeroo#447

yeah thank you

[caoimhebyrne]

I think ChatTools should be compatible with this now, I've committed it to another branch until I do some more testing, see 3568670.

https://github.com/70CentsApple/ChatTools/blob/1.20/src/main/java/net/apple70cents/chattools/mixin/ChatHudMixin.java

[caoimhebyrne]

Going to keep this open until the release is public.

[caoimhebyrne]

This has now been published to Modrinth and GitHub Releases.

[70CentsApple]

Hey! I'm sorry to inform you that such issue can be easily reproduced once again in MC 1.20.4 due to some probable reasons. However, I'm glad to inform that I have already figure it out and I could make a PR for that! @caoimhebyrne