Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected documentation for importing quote macro #5422

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

immortalcodes
Copy link
Member

@immortalcodes immortalcodes commented Dec 3, 2024

Done

  • Corrected documentation for importing quote macro
  • vf_quote-wrapper gave error when imported

QA

  • Open demo and see if the import statement is corrected

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@bartaz bartaz added Review: QA needed Review: Code +1 Documentation 📝 Documentation changes or updates Review: Percy needed This PR needs a review of Percy for visual regressions labels Dec 3, 2024
@immortalcodes immortalcodes marked this pull request as ready for review December 3, 2024 08:56
@bartaz bartaz added Review: QA +1 Review: Percy +1 and removed Review: QA needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Dec 3, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@bartaz bartaz merged commit ac48446 into main Dec 3, 2024
15 checks passed
@bartaz bartaz mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants