Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic themes documentation #5378

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add basic themes documentation #5378

merged 1 commit into from
Oct 17, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Oct 10, 2024

Done

Updates some legacy themes documentation.

Fixes https://warthogs.atlassian.net/browse/WD-7593

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@bartaz bartaz added the Documentation 📝 Documentation changes or updates label Oct 10, 2024
@webteam-app
Copy link

@bartaz bartaz added Review: QA needed Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 10, 2024
@jmuzina jmuzina added Review: QA +1 Review: Percy +1 and removed Review: QA needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Oct 11, 2024
@bartaz bartaz merged commit de55956 into canonical:main Oct 17, 2024
12 checks passed
@bartaz bartaz deleted the themes-docs branch October 17, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants