Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply form generator and remove stale templates #14714

Open
wants to merge 2 commits into
base: k8s-bubble-refresh
Choose a base branch
from

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Feb 5, 2025

Done

  • Added form-data.json as per doc for bubble and updated import throughout
  • Drive by's:
    • Deleted stale k8s partials
    • Applied copy update

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-18335

@webteam-app
Copy link

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (c31fb4b) to head (1a16351).
Report is 85 commits behind head on k8s-bubble-refresh.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           k8s-bubble-refresh   #14714      +/-   ##
======================================================
- Coverage               72.58%   72.32%   -0.26%     
======================================================
  Files                     120      120              
  Lines                    3392     3404      +12     
  Branches                 1171     1177       +6     
======================================================
  Hits                     2462     2462              
- Misses                    906      917      +11     
- Partials                   24       25       +1     

see 1 file with indirect coverage changes

@mtruj013 mtruj013 changed the title Add bubble form data, delete stale partials, and apply copy update feat: Apply form generator and remove stale templates Feb 5, 2025
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marketo submission doesn't go through because it is missing one of the comment fields. I left a suggestion and it should fix the issue. Otherwise everything else looks good!

templates/kubernetes/form-data.json Outdated Show resolved Hide resolved
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, its being added to the payload now. There's still a bug where the form submission does not go through Marketo, can you have a look into it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants