-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Apply form generator and remove stale templates #14714
base: k8s-bubble-refresh
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## k8s-bubble-refresh #14714 +/- ##
======================================================
- Coverage 72.58% 72.32% -0.26%
======================================================
Files 120 120
Lines 3392 3404 +12
Branches 1171 1177 +6
======================================================
Hits 2462 2462
- Misses 906 917 +11
- Partials 24 25 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marketo submission doesn't go through because it is missing one of the comment fields. I left a suggestion and it should fix the issue. Otherwise everything else looks good!
Co-authored-by: Britney Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, its being added to the payload now. There's still a bug where the form submission does not go through Marketo, can you have a look into it please?
Done
form-data.json
as per doc for bubble and updated import throughoutQA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-18335