Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use image template for logo on u.com #14713

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Use image template for logo on u.com #14713

wants to merge 2 commits into from

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Feb 5, 2025

Done

  • updated the images we were pulling directly from the asset manager to use the image-template (and this cloudinary)
  • render the decoration images as jpeg (see example below)
  • Bump the version of the image-template

QA

  • Check that the logos are the same in the demo as they are on the live page
  • Check no quality is lost and all alt text is retained

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-19037

Screenshots

image

@webteam-app
Copy link

@petesfrench
Copy link
Contributor Author

@mattea-turic Can you take a look at this please and let me know if the quality is good?

@mattea-turic
Copy link
Collaborator

mattea-turic commented Feb 5, 2025

@petesfrench quality looks good but there's a tiny line here since the image isn't at precise pixels

Screenshot 2025-02-05 at 14 57 57

Added jpgs here that should prevent that white line – @1x and @2x. 1x should be fine, but I added 2x in case the quality isn't quite there on larger screens

@petesfrench
Copy link
Contributor Author

@mattea-turic I updated the image to the 1x version. Can you tell me if it is good enough quality please

@mattea-turic
Copy link
Collaborator

@petesfrench perfect :) will +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants