feat: Create a template for individual vulnerability pages #14708
Conversation
Demo
Jenkins 
demos.haus 
|
Hey @eliman11, this is the vulnerabilities page we spoke about. You can see it at this demo link. I am open to any suggestions. Bare in mind we don't have full control over the content. But we do get 'chunks' of content that we can put where we want. The screenshot below indicate what the 'chunks' are with a red box. You will notice it is a series of 'titles' and then the associated 'content'.
|
I don't see the retbleed notification on /security page, just these: |
|
On medium and small screens, there is some white padding on the right side of the page The table of content is also hidden, I assume there should be a "Toggle table of contents" button but it is not shown either |
| <div class="u-fixed-width"> | ||
| <a href="/security/vulnerabilities" class="p-link--soft">⟨ Back to all vulnerabilities</a> | ||
| </div> |
There was a problem hiding this comment.
Can we use the Vanilla breadcrumb component here?
There was a problem hiding this comment.
Good shout! The repeating did feel a little hacky
|
Thanks for all your work on this @petesfrench, it looks great! Just one more tiny adjustment I promise - can we change the wording on the button into "> Open side navigation" rather than "> Toggle side navigation" and "< Close side navigation" to collapse it on smaller screens? I'll add UX+1 anyway though - thank you again! |
| toggleButtonOutsideDrawer.setAttribute("aria-expanded", "false"); | ||
| toggleButtonInsideDrawer.setAttribute("aria-expanded", "false"); | ||
| toggleButtonOutsideDrawer?.setAttribute("aria-expanded", "false"); | ||
| toggleButtonInsideDrawer?.setAttribute("aria-expanded", "false"); | ||
| } |
There was a problem hiding this comment.
A suggestion here would be to add some helper classes to reduce redundancy and improve readability.
For example we can have toggleSideNavClass(addClass, removeClass) for lines 25-26 and 34-35.
We can also have another helper class for setting aria-expanded i.e setAriaExpanded(expanded) to handle lines 31-32 and 40-41.
Done
QA
Discourse post for retbleed
Demo page for retbleed
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-17114