Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-18591] Ref: Use form generator on "u.com/embedded" #14684

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 28, 2025

Done

  • Added 'setupOtherInputs' method from c.com to setup fields that require additional input.
  • Added form-data.json for embedded form
  • Updated form-fields.html to reflect 'other-input'
  • Added a slug filter

QA

  • Open the demo in your browser
  • Fill all the fields and submit the form
  • Make sure the form submission works and also verify from Marketo side if possible.
  • Try a few times with different submissions.
  • Make sure the form is redirected to contact-success-banner.

Issue / Card

Fixes #WD-18591

@webteam-app
Copy link

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (c4540a6) to head (d9f908a).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
static/js/src/prepare-form-inputs.js 28.57% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14684      +/-   ##
==========================================
- Coverage   72.32%   72.14%   -0.18%     
==========================================
  Files         120      120              
  Lines        3404     3418      +14     
  Branches     1172     1179       +7     
==========================================
+ Hits         2462     2466       +4     
- Misses        917      926       +9     
- Partials       25       26       +1     
Files with missing lines Coverage Δ
static/js/src/prepare-form-inputs.js 61.19% <28.57%> (-8.62%) ⬇️

@muhammad-ali-pk muhammad-ali-pk changed the title [WD-18591] Ref: Use form generator on embedded contact form [WD-18591] Ref: Use form generator on "/embedded" Jan 28, 2025
@muhammad-ali-pk muhammad-ali-pk changed the title [WD-18591] Ref: Use form generator on "/embedded" [WD-18591] Ref: Use form generator on "u.com/embedded" Jan 28, 2025
Copy link
Member

@samhotep samhotep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants