Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up after static analysis #185

Merged
merged 7 commits into from
May 29, 2024
Merged

Tidy up after static analysis #185

merged 7 commits into from
May 29, 2024

Conversation

AlanGriffiths
Copy link
Contributor

Fix true positives

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner May 28, 2024 15:50
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and makes sense 👍 I am unsure how to test check_for_exposed_outputs properly though. I can trust that it works, but if you have a simple repo that I could try that would be good too

@AlanGriffiths
Copy link
Contributor Author

The code looks good and makes sense 👍 I am unsure how to test check_for_exposed_outputs properly though. I can trust that it works, but if you have a simple repo that I could try that would be good too

As previously discussed, we need better test rigging in this area. And, I think, the logic for overlapping, non-identical, outputs is suspect.

I trust it is clear that this rework doesn't break anything that worked before. (I could drop 59868aa, the "extract method" refactor should be uncontentious.

@mattkae mattkae added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 8e509db May 29, 2024
3 checks passed
@mattkae mattkae deleted the fix-code branch May 29, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants