[Merged by Bors] - Automate reloading display configuration #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviq
reviewed
Jan 25, 2023
Saviq
reviewed
Jan 26, 2023
Saviq
reviewed
Jan 26, 2023
AlanGriffiths
force-pushed
the
automate-display-configuration
branch
from
7f1ebee to
03a2c7b
Compare
AlanGriffiths
force-pushed
the
automate-display-configuration
branch
from
03a2c7b to
2518dce
Compare
Saviq
reviewed
Jan 27, 2023
I suspect the reason is that the file exists ( |
No |
|
bors merge too |
bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
This allows Frame to handle display reconfiguration without a restart. Features: 1. If there is no `display` option set, then when Frame runs it is set to a default 2. When the `display` option is set: 2.1. With Miral < 3.8 Frame is restarted and will load the new display configuration 2.2. With Miral 3.8 Frame is not restarted and will attempt to reload 3. When the display option is unset, the configuration is cleared and Frame restarted Note: there is (still) no validation of the configuration being set Fixes: #20
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Frame to handle display reconfiguration without a restart.
Features:
displayoption set, then when Frame runs it is set to a defaultdisplayoption is set:2.1. With Miral < 3.8 Frame is restarted and will load the new display configuration
2.2. With Miral 3.8 Frame is not restarted and will attempt to reload
Note: there is (still) no validation of the configuration being set
Fixes: #20