Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not respecting snap-name #172

Closed
kylecarhart opened this issue Mar 11, 2024 · 5 comments · Fixed by canonical/mir#3294 or canonical/mir#3299
Closed

Not respecting snap-name #172

kylecarhart opened this issue Mar 11, 2024 · 5 comments · Fixed by canonical/mir#3294 or canonical/mir#3299
Assignees
Labels
bug Something isn't working needs test triaged Triage into JIRA to plan it in

Comments

@kylecarhart
Copy link

kylecarhart commented Mar 11, 2024

Following this tutorial: https://discourse.ubuntu.com/t/how-to-configure-ubuntu-frame-for-multiple-outputs/33012

I am trying to set snap-name in my display config but it does not appear to take any effect. For example, I would like mir-kiosk-neverputt on my second monitor.

# ...
      HDMI-A-4:
        state: enabled  # {enabled, disabled}, defaults to enabled
        mode: [email protected]    # Defaults to preferred mode
        position: [2560, 0]     # Defaults to [0, 0]
        orientation: normal   # {normal, left, right, inverted}, defaults to normal
        scale: 1
        group: 0        # Outputs with the same non-zero value are treated as a single display
        snap-name: mir-kiosk-neverputt

Working on my config in a separate file, then I cat it out to snap set: sudo snap set ubuntu-frame display=...

However when checking snap logs ubuntu-frame -n 50, I can see that my config has been stripped of the snap-name I provided...

2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:       HDMI-A-4:
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         state: enabled	# {enabled, disabled}, defaults to enabled
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         mode: [email protected]	# Defaults to preferred mode
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         position: [2560, 0]	# Defaults to [0, 0]
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         orientation: normal	# {normal, left, right, inverted}, defaults to normal
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         scale: 1
2024-03-11T15:47:37-04:00 ubuntu-frame.daemon[1182]:         group: 0	# Outputs with the same non-zero value are treated as a single display

Anything that I could be doing wrong here?

@kylecarhart
Copy link
Author

Update... uninstalling ubuntu-frame and reinstalling with channel 20 seems to fix this.

@Saviq
Copy link
Collaborator

Saviq commented Mar 12, 2024

Thanks @kylecarhart, I can confirm this isn't working as intended, we'll get a fix in asap.

@Saviq Saviq added bug Something isn't working triaged Triage into JIRA to plan it in labels Mar 12, 2024
@Saviq
Copy link
Collaborator

Saviq commented Mar 12, 2024

In fact, I can't seem to get it to work on 20, either, both give me:

< -warning- > miral: Attempt to read custom output attribute (surface-title) that wasn't added
< -warning- > miral: Attempt to read custom output attribute (snap-name) that wasn't added    

Though that's only on startup, so may be before we've asked for them?

@AlanGriffiths
Copy link
Contributor

I can confirm this works on the 20 track and not on the 22 track.

@AlanGriffiths
Copy link
Contributor

AlanGriffiths commented Mar 27, 2024

The fix is available on edge. We will shortly be releasing Mir 2.16.4 with the fix, that version will be then be available on beta and, following internal testing, on candidate and then, after a "call for testing" on stable.

github-merge-queue bot pushed a commit to canonical/mir that referenced this issue Apr 8, 2024
## Release Notes
mir (2.16.4) UNRELEASED; urgency=medium

  * Bugfix release:
    - Ignoring zero length gamma curves for KMS outputs (Fixes: #3238)
    - Add hardware cursor support (Fixes: #3198)
- Screenshots now respect clipping areas and rotated outputs (Fixes:
#3236)
      (Fixes: #3259)
    - Fixed custom attributes propagation on outputs
      (Fixes: canonical/ubuntu-frame#172)
    - Handle the Ubuntu 64-bit time_t apocalypse (Fixes: #3285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs test triaged Triage into JIRA to plan it in
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants