Environment issues followup #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejvelichkovski
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This change looks good to me, but I was just thinking that we are sort-of introducing a bit of inconsistency here, as in other data models we treat empty string as no data, such as the Artefact identifiers (series/repo/..) but here we have nullable field as well.
|
I agree that there's an inconsistency. I followed what we did for ci_link and c3_link which are both nullable. Perhaps it would make sense to open a PR at some point that would make all such examples consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of followup changes from environment issues story:
Resolved issues
Resolves https://warthogs.atlassian.net/browse/RTW-364
Documentation
Web service API changes
Tests
Updated backend tests. Then tested front-end manually.