-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTW-313: Implement percentage completed UI #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful feature!
grouped_builds[build.architecture].append(build) | ||
|
||
return [ | ||
max(builds, key=lambda b: b.revision if b.revision else 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omar-selo can you please help me verify that it is fine to assign revision to 0 if it is None. Mypy was complaining because the key here can be null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This change implements a progress bar that indicates how many of the Test Executions in an Artefact have been completed ( reviewed).
There are two parts to this implementation:
We solve case (1) with front-end only changes. To resolve case (2) we also implement a backend change, to expose the following two parameters for all artefacts available:
all_test_executions_count
completed_test_executions_count
UI component changes
Dashboard
Artefact View
Updated tooltip
Resolved issues
This PR resolves RTW-313.
Documentation
This is a UX improvement and we don't have any documentation for such components yet.
Web service API changes
The change adds two fields to the
ArtefactDTO
, both integers. There are currently two endpoints that returnArtefactDTO
objects:/artefacts
/artefacts/{ID}
Tests
This change was both manually tested and an automated test was added
Known limitations
Currently, we only fetch the dashboard page when we firstly load the page, to avoid making extra requests. This limits the correctness of data we show on the dashboard. Consider the following case: