Fix parsing of power parameters #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consumes and depends on: canonical/gomaasclient#16 |
skatsaounis
force-pushed
the
fix-power-parameters
branch
3 times, most recently
from
7a5e327
to
453fa28
Compare
skatsaounis
force-pushed
the
fix-power-parameters
branch
from
453fa28
to
e3936dd
Compare
skatsaounis
force-pushed
the
fix-power-parameters
branch
from
e3936dd
to
da35440
Compare
troyanov
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the handling of machines with power parameters that contain nested parameters, like IPMI
workaround_flags.Unfortunately, Terraform sdk cannot handle situations when a map contains elements of different types. Thus, with the existing implementation, we can handle only machines with power parameters which are
map[string]string. As a usual design workaround, thepower_parametersis turned to aschema.TypeStringwhich includes a serialized JSON.With the above change in the field, we are able to manage (import, create, update) machines of type IPMI.