Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datasources for machine and physical nic #7

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add datasources for machine and physical nic #7

merged 4 commits into from
Nov 16, 2023

Conversation

ianmcmahon
Copy link
Contributor

Create datasources for existing machines and physical nics

@sempervictus sempervictus mentioned this pull request Oct 6, 2022
Closed
cpg1111
cpg1111 requested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@cpg1111 cpg1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue with missing format, otherwise, looks good.

maas/provider.go Outdated Show resolved Hide resolved
ironashram added a commit to ironashram/terraform-provider-maas that referenced this pull request Oct 5, 2023
@ironashram
import chanages from canonical#7
ea133a0
ironashram added a commit to ironashram/terraform-provider-maas that referenced this pull request Oct 5, 2023
@ironashram
import changes from canonical#7
0cdead7
@ironashram ironashram mentioned this pull request Oct 6, 2023
Closed
@skatsaounis
Copy link
Collaborator

Hi @ianmcmahon

I know it has been a while since you opened this PR but we are interested in adding these data sources to the provider. Would you still like to contribute to this PR or should we proceed with our implementation? If yes, feel free to reach out for help if needed :)

@troyanov troyanov self-requested a review October 9, 2023 11:51
troyanov
troyanov previously approved these changes Oct 9, 2023
View reviewed changes
@troyanov troyanov requested review from cpg1111 and removed request for cpg1111 October 9, 2023 11:56
skatsaounis
skatsaounis requested changes Oct 9, 2023
View reviewed changes
maas/data_source_maas_machine.go Outdated Show resolved Hide resolved
@ironashram
Copy link
Contributor

ironashram commented Oct 11, 2023 •
edited
Loading

@troyanov for my use case (and i suppose for many more) it would be needed to fetch the maas_machine datasource with pxe_mac_address as input, since the hostname which is currently used here is not predictable in case the machine has been discovered automatically

My fork already has this, it may not be the cleanest but it works quite well

@skatsaounis skatsaounis force-pushed the datasources branch 3 times, most recently from 7943029 to 683d389 Compare November 16, 2023 14:20
skatsaounis
skatsaounis previously approved these changes Nov 16, 2023
View reviewed changes
@skatsaounis skatsaounis self-requested a review November 16, 2023 14:20
@skatsaounis
Copy link
Collaborator

@ironashram I incorporated most of what you have in your fork, since it makes a lot of sense. At last, we are ready to run our e2e tests and get some approval here 🎉

cpg1111
cpg1111 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@cpg1111 cpg1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skatsaounis skatsaounis merged commit 4c374bd into canonical:master Nov 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyanov troyanov troyanov left review comments

@cpg1111 cpg1111 cpg1111 approved these changes

@skatsaounis skatsaounis skatsaounis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ianmcmahon @skatsaounis @ironashram @troyanov @cpg1111