Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly import physical interfaces #169

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: properly import physical interfaces #169

merged 2 commits into from
Apr 17, 2024

Conversation

skatsaounis
Copy link
Collaborator

@skatsaounis skatsaounis commented Apr 11, 2024 •
edited
Loading

This PR includes the following changes:

  • Change the delimiter of importing physical interfaces from : to /
  • Allow import by MAC Address as advertised
  • Do not break idempotency when importing existing resources
  • Add acceptance tests for physical interfaces

Fixes: #163

troyanov
troyanov previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@troyanov troyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small nitpick

maas/resource_maas_network_interface_physical.go Outdated Show resolved Hide resolved
@skatsaounis skatsaounis merged commit 44818cf into canonical:master Apr 17, 2024
7 checks passed
@skatsaounis skatsaounis deleted the fix-import-physical-interfaces branch April 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyanov troyanov troyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Importing and renaming physical interface tends to remove machine instead
2 participants
@skatsaounis @troyanov