kvm-test: set cloud-config disk after real disks #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the disks used for installation are passed to kvm first
and not the disk with cloud-config/autoinstall data. Sometimes
curtin will put paths to disk in the fstab like:
/dev/disk/by-path/pci-000n-xxxx/by-uuid/UUID
and when we reboot without the cloud-config disk the path to the
install disk will change since the number of pci devices connected
to the machine has technically changed. We can make this a little more
stable by letting the cloud-config drive be the last drive attached.
|
I've never run into this issue I think. Is it something new in Oracular? |
dbungert
approved these changes
Sep 16, 2024
|
Yeah I hadn't run into it until recently. Definitely feels like like something new in Oracular. |
Not completely at least. I ran into a conflict here with grub and upgrade testing during mantic, where grub was keeping track of the relevant device but I had changed the device due to kvm-test drive ordering. The LP bug escapes me at the moment. |
|
This looks relevant: https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/2081256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the disks used for installation are passed to kvm first and not the disk with cloud-config/autoinstall data. Sometimes curtin will put paths to disk in the fstab like:
and when we reboot without the cloud-config disk the path to the install disk will change since the number of pci devices connected to the machine has technically changed. We can make this a little more stable by letting the cloud-config drive be the last drive attached.