predictably arbitrary disk selection #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If two disks of the same size went to the disk matchers with the default "largest" match, the one we would choose would be based on whatever order in python they ended up, and across installs this means that we could select arbitrarily among disks of a matching size. Add sort criteria based on various unique identifiers. Make it work for other disk-like devices, though the main target is disks and raids because that's what can go to the matcher system.
mwhudson
approved these changes
Aug 9, 2024
|
@medicalwei - FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filesystem: arbitrary disk select more consistent
If two disks of the same size went to the disk matchers with the default
"largest" match, the one we would choose would be based on whatever
order in python they ended up, and across installs this means that we
could select arbitrarily among disks of a matching size.
Add sort criteria based on various unique identifiers. Make it work for
other disk-like devices, though the main target is disks and raids
because that's what can go to the matcher system.