Fix dry-run mode with Pro enabled. #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhudson
force-pushed
the
dry-run-vs-pro
branch
2 times, most recently
from
9f3ed2b
to
2f694a8
Compare
ogayot
approved these changes
Aug 8, 2024
subiquity/server/mounter.py
Outdated
| r.append(name) | ||
| return r | ||
|
|
||
| shutil.copytree(f"{source}/etc/apt", f"{target}/etc/apt", ignore=_ignore_pro) |
There was a problem hiding this comment.
Alternatively, you can use ignore=shutil.ignore_patterns("*esm*", "*advantage*"), that I just learnt about.
There was a problem hiding this comment.
Oh yes, I saw that but somehow blanked on the fact that I could use it for my needs.
Chris-Peterson444
approved these changes
Aug 8, 2024
In dry run mode we copy the apt config from the running system into the "target". Some files associated with Ubuntu Pro are not readable to regular users and they aren't required to get some kind of working config in the target so skip them.
mwhudson
force-pushed
the
dry-run-vs-pro
branch
from
2f694a8
to
97c5990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dry run mode we copy the apt config from the running system into the "target". Some files associated with Ubuntu Pro are not readable to regular users and they aren't required to get some kind of working config in the target so skip them.