Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cloudinit): do not call cloudinit stages.Init when disabled #1923

Merged

Conversation

blackboxsw
Copy link
Collaborator

Inspect cloud-init status for disabled. When disabled do not call stages.Init due to a side-effect that cloud-init tries to rediscover any viable datasource when none are previously discovered.

LP: #2055077

subiquity/server/server.py Outdated Show resolved Hide resolved
@blackboxsw blackboxsw force-pushed the cloudinit-no-init-when-disabled branch 3 times, most recently from ee45667 to dddb441 Compare March 2, 2024 00:02
Inspect cloud-init status for disabled. When disabled do not
call stages.Init due to a side-effect that cloud-init tries to
rediscover any viable datasource when none are previously
discovered.

LP: #2055077
@blackboxsw blackboxsw force-pushed the cloudinit-no-init-when-disabled branch from dddb441 to 972e0d5 Compare March 2, 2024 00:03
Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had expected that unit test to be less painful, thanks for doing so.

@dbungert dbungert merged commit d010f92 into canonical:main Mar 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants