codecs: attempt install on first boot if install fails #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of giving up installing ubuntu-drivers-addons if we are not online (or if another error occurs), we now fall back to asking cloud-init to install the package on first boot. Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
install-package-failover-cloud-init
branch
from
52ffcde
to
4df7e0e
Compare
dbungert
reviewed
Sep 18, 2023
Sadly, I have yet to witness a scenario where it really helps in practice - so I don't think we should merge for mantic. Maybe we should apply this to other packages as well - and somehow have a way to inform the users that said packages are going to be installed on first boot. Errors on first boot look pretty bad too .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of giving up installing ubuntu-drivers-addons if we are not online (or if another error occurs), we now fall back to asking cloud-init to install the package on first boot.
If we were doing an offline install, it is highly likely that cloud-init will also fail to install the package on first boot. Furthermore, it will only try to install it once before disabling itself.
So, this change would only be beneficial in scenarios where a temporary network failure is encountered.