Ensure the security archive is set to the proper URL #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbungert
reviewed
Sep 8, 2023
Mirror testing should focus on testing the primary mirror, not the security archive - therefore we disable the -security suite. Signed-off-by: Olivier Gayot <[email protected]>
When the URL of the security archive is unset, curtin will set it to the URL of the primary archive. This is not the behavior we want for Ubuntu installations. On amd64 (and i386), the URL of the security archive should be set to http://security.ubuntu.com/ubuntu On other architectures, it should be set to http://ports.ubuntu.com/ubuntu-ports Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
security-archive
branch
from
b9c7226
to
ef3974d
Compare
dbungert
approved these changes
Sep 8, 2023
Signed-off-by: Olivier Gayot <[email protected]>
ogayot
force-pushed
the
security-archive
branch
from
ef3974d
to
75ab969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced as part of mirror testing.
On new Ubuntu installations, the -security pocket is accessed through the primary mirror instead of being accessed through security.ubuntu.com/ubuntu (or ports.ubuntu.com/ubuntu-ports)
This happens because when no
securitysection is provided to curtin, the value configured in theprimarysection is reused.We now ensure that the right URI is used for the security repository.
It has a slight impact on the behavior of mirror testing though. Instead of downloading content from the primary repository only, we would download content from the primary+security repository. Therefore, we would try all the candidate mirrors without success is the security repository is unreachable. To work around this issue, we now disable the -security suite when running mirror testing. This requires a fix in curtin for releases that use deb822 sources: https://code.launchpad.net/~ogayot/curtin/+git/curtin/+merge/450893