Bootable disks #1634
Merged
Bootable disks #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
approved these changes
Apr 4, 2023
| @@ -306,16 +306,10 @@ class reformat_disk: | |||
| def POST(data: Payload[ReformatDisk]) \ | |||
| -> StorageResponseV2: ... | |||
|
|
|||
| class potential_boot_disks: | |||
There was a problem hiding this comment.
I assume the desktop installer is the only consumer we know of for this endpoint. When we backport this fix, should we still keep the existing endpoint? This feels like a breaking change.
There was a problem hiding this comment.
this is fine to remove. :) it was added to the dart API but didn't end up being used in the GUI yet as discussed yesterday
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the disks as can_be_boot_disk, instead of a separate API call.