snaplist: do not automatically mark configured on failed GET request #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a client sends a GET /snaplist request and an error occurs on the
server side, we return a response of the following form:
{ "status": "FAILED", ... }
This effectively gives a chance to the client to retry the same request
and expect a different outcome (for instance when a temporary network
failure occurs).
Having said that, when the server returns "status": "FAILED", it also
automatically marks the snaplist model configured. This is wrong because
if the next GET /snaplist request succeeds, the user will be prompted to
select some snaps to install ; but the installation will already be
running in the background. Depending on the timing, it might or might
not install the snaps that the user selected.
Fixed by not marking the snaplist model configured automatically. The
client is made responsible from sending a POST /snaplist ; even in case
of error.
Signed-off-by: Olivier Gayot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client sends a
GET /snaplistrequest and an error occurs on the server side, we return a response of the following form:{ "status": "FAILED", ... }This effectively gives a chance to the client to retry the same request and expect a different outcome (for instance when a temporary network failure occurs).
Having said that, when the server returns
"status": "FAILED", it also automatically marks the snaplist model configured. This is wrong because if the nextGET /snaplistrequest succeeds, the user will be prompted to select some snaps to install ; but the installation will already be running in the background. Depending on the timing, it might or might not install the snaps that the user selected.Fixed by not marking the snaplist model configured automatically. The client is made responsible from sending a
POST /snaplist; even in case of error.Addresses the following bug report:
https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1989179