console-conf: fix crash on network info #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you run dryrun for console-conf, go to the network page, go to an interface, then info, a crash of the form TypeError: object str can't be used in 'await' expression can be seen. The signature for the core version of get_info_for_netdev is not async, but a non-async method returning str. So mark the core version of the function async. Co-authored-by: Michael Hudson-Doyle <[email protected]> (cherry picked from commit 4b1277a)
|
For https://bugs.launchpad.net/subiquity/+bug/1978339. The core22 snap is following this branch but specifies a commit so that will need to be updated too. |
ogayot
approved these changes
Jun 13, 2022
|
Thanks! I was under the impression that the next release would be based on main though? |
It will be, but this branch is still available for maintenance things. So this still helps. |
dbungert
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run dryrun for console-conf, go to the network page, go to an
interface, then info, a crash of the form
TypeError: object str can't be used in 'await' expression
can be seen. The signature for the core version of get_info_for_netdev
is not async, but a non-async method returning str.
So mark the core version of the function async.
Co-authored-by: Michael Hudson-Doyle [email protected]
(cherry picked from commit 4b1277a)