cmd/snap-confine: Support bash as base runtime entry #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows bash that makes use of readline + ncurses to correctly map and execute within strict apparmor confinement, specifically required for enabling bash-based base runtimes (such as Solus). Signed-off-by: Ikey Doherty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4197 +/- ##
=======================================
Coverage 75.57% 75.57%
=======================================
Files 436 436
Lines 37830 37830
=======================================
Hits 28590 28590
Misses 7245 7245
Partials 1995 1995Continue to review full report at Codecov.
|
mvo5
approved these changes
Nov 9, 2017
|
I'm not supper happy about this. Ideally we will remove the only reason this is needed (snappy-app-dev) CC @jdstrand If we cannot avoid it then +1 but I'd like to really remove that shell script and not have to have extra permissions here. |
bboozzoo
approved these changes
Nov 10, 2017
jdstrand
approved these changes
Nov 10, 2017
joebonrichie
pushed a commit
to solus-packages/snapd
that referenced
this pull request
Aug 15, 2023
These changes are undergoing review upstream and are required to support a Solus derived runtime, for the LSI efforts and more. - canonical/snapd#4197 - canonical/snapd#4199 Effectively this introduces support for biarch multilib drivers, i.e. the 32-bit NVIDIA drivers, within the snap. Additionally it adds support for using bash as an entry point as opposed to dash. Signed-off-by: Ikey Doherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows bash that makes use of readline + ncurses to correctly map
and execute within strict apparmor confinement, specifically required
for enabling bash-based base runtimes (such as Solus).
Signed-off-by: Ikey Doherty [email protected]