cmd/snap-confine: Respect biarch nature of libdirs #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the same bi-arching seen in other parts of the policy and ensures snap-update-ns rules are actually matched on biarch distributions employing a lib64 tree. Signed-off-by: Ikey Doherty <[email protected]>
|
Between this PR and #4182 - snapd 2.29.2 works on Solus fully! :) |
mvo5
approved these changes
Nov 9, 2017
The test relies on the "old" snapd-xdg-open deb package. However with the promotion of snapd 2.28.5 into xenial-updates the pervious snapd-xdg-open version 0.0.0~16.04 is no longer available to download. This means we can not run the test. Disable for now until we find a way to fix it.
Codecov Report
@@ Coverage Diff @@
## master #4183 +/- ##
==========================================
+ Coverage 75.53% 75.54% +<.01%
==========================================
Files 436 436
Lines 37811 37805 -6
==========================================
- Hits 28562 28559 -3
+ Misses 7253 7251 -2
+ Partials 1996 1995 -1
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same bi-arching seen in other parts of the policy and
ensures snap-update-ns rules are actually matched on biarch distributions
employing a lib64 tree.
Signed-off-by: Ikey Doherty [email protected]