Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/snap-confine: Ensure snap-confine is allowed to access os-release #4182

Merged
merged 2 commits into from
Nov 9, 2017
Merged

cmd/snap-confine: Ensure snap-confine is allowed to access os-release #4182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45d7199
cmd/snap-confine: Ensure snap-confine is allowed to access os-release
ikeydoherty Nov 8, 2017
d9444a2
tests: disable xdg-open-compat test
mvo5 Nov 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/snap-confine/snap-confine.apparmor.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@
umount /var/lib/snapd/hostfs/proc/,
mount options=(rw rslave) -> /var/lib/snapd/hostfs/,

# Allow reading the os-release file (possibly a symlink to /usr/lib).
/{etc/,usr/lib/}os-release r,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What puzzles me is why we did not notice this earlier, I think we have a missing (spread) test here :/


# set up snap-specific private /tmp dir
capability chown,
/tmp/ w,
Expand Down
4 changes: 4 additions & 0 deletions tests/main/xdg-open-compat/task.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ description: |
# we must have snapd-xdg-open available
systems: [ubuntu-16.04-*]

# disabled because the "old" snapd-xdg-open is no longer available in the
# archive
manual: true

environment:
DISPLAY: :0
XDG_OPEN_OUTPUT: /tmp/xdg-open-output
Expand Down