snap-confine: Ensure lib64 biarch directory is respected

[ikeydoherty]

This fixes a 2.28+ regression whereby snap-update-ns no longer works
due to the strict apparmor rules.

Signed-off-by: Ikey Doherty [email protected]

[Conan-Kudo]

If you're actually adding support for biarch locations and you don't have a dedicated libexec dir, then you should probably add all of the multilib directories to this.

[ikeydoherty]

In Solus the "dedicated libexecdir" is "named subdir of libdir". I'm not sure how many distros do this, and I'm kinda doubtful we'd see lib32, libx32 variants on top of that. But, if they exist, then sure. This one is a bit less important than my other PRs anyway.

[codecov-io]

Codecov Report

Merging #3980 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3980      +/-   ##
==========================================
+ Coverage   75.97%   75.97%   +<.01%     
==========================================
  Files         423      423              
  Lines       36505    36505              
==========================================
+ Hits        27734    27735       +1     
+ Misses       6833     6832       -1     
  Partials     1938     1938

Impacted Files	Coverage Δ
cmd/snap/cmd_aliases.go	95% <0%> (+1.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7d79c...aad4f90. Read the comment docs.

[Conan-Kudo]

@ikeydoherty As it's trivial and Yocto and Gentoo allow this as an option when building them, I would suggest going for it.

[zyga]

+1

[mvo5]

Thanks, I will cherry pick this into release/2.28 - where do we have the regressions? solus?

[mvo5]

Aha, this is only breaking in master, right?

[jdstrand]

Was asked to review, but already merged....

This LGTM.

[ikeydoherty]

Yeah only cropped up on Solus - but ya, cheers for merge.