cmd: Correctly name the "Ubuntu" and "Arch" NVIDIA methods

[ikeydoherty]

Applying distribution names to widely used methods is a little disingenuous,
so let's say what they really arch. The "Ubuntu" method is in reality a
management method employed only on multiarch Linux distributions, used on
Ubuntu and portable to Debian.

The "Arch Linux" method is in fact just how classic "bi-arch" Linux
distributions work, i.e. multilib systems with lib32/lib64.

Signed-off-by: Ikey Doherty [email protected]

[ikeydoherty]

Fair disclaimer: This one is a bit opinionated.

[codecov-io]

Codecov Report

Merging #3978 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3978      +/-   ##
==========================================
+ Coverage   75.97%   75.98%   +<.01%     
==========================================
  Files         423      423              
  Lines       36505    36505              
==========================================
+ Hits        27734    27737       +3     
+ Misses       6833     6830       -3     
  Partials     1938     1938

Impacted Files	Coverage Δ
overlord/ifacestate/helpers.go	63% <0%> (+0.66%)	⬆️
cmd/snap/cmd_aliases.go	95% <0%> (+1.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7d79c...a8e69af. Read the comment docs.

[Conan-Kudo]

I would suggest renaming them to debian-multiarch and multilib, as there are other schemes of multiarch (such as the scheme used by Exherbo).

[Conan-Kudo]

As an aside, I don't think this code is actually working like it should, as I don't see where it would match code installed in multilib/biarch directory paths.

For example, Fedora and openSUSE install the libraries to /usr/lib64 as opposed to /usr/lib, and I thought Solus did the same.

[mvo5]

I like this rename, thanks for doing this! I would really like to keep the old configure options around for compatibility for a little bit in configure just so that downstream packagers (we might not know) don't get their packaging broken (showing a deprecation warning). But maybe this is not really needed given that we know most of our packagers.

[Conan-Kudo]

@mvo5 I think when it comes to build-side configure flags, I don't think deprecation warnings are necessary beyond just throwing an error (and kill the build) when the old option is used.

[zyga]

LGTM, feel free to iterate on the name (agree upon something locally at the rally please)

[ikeydoherty]

We could have a nasty compatibility set of options .. :)

[zyga]

@ikeydoherty trivial conflict in one file after merging other nvidia PR

[ikeydoherty]

ok