Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: Enhance full-confinement support for biarch distributions #3977

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

ikeydoherty
Copy link
Contributor

This change adds support for those using the "Arch Linux" (biarch) style
symlink farms for NVIDIA driver support when using full apparmor confinement.

Additionally this change adds support for the linux-driver-management method for
managing the host-side drivers, whereby the glx-provider/*/ directories
are populated with the real library assets, with symlinks in the main
library directories being pointed to these locations.

Signed-off-by: Ikey Doherty [email protected]

This change adds support for those using the "Arch Linux" (biarch) style
symlink farms for NVIDIA driver support when using full apparmor confinement.

Additionally this change adds support for the linux-driver-management method for
managing the host-side drivers, whereby the `glx-provider/*/` directories
are populated with the real library assets, with symlinks in the main
library directories being pointed to these locations.

Signed-off-by: Ikey Doherty <[email protected]>
Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ikeydoherty
Copy link
Contributor Author

Derp - forgot to push the opengl-test

@ikeydoherty
Copy link
Contributor Author

Nope nvm looks like its not needed anymore..

@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #3977 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3977      +/-   ##
==========================================
+ Coverage   75.97%   75.97%   +<.01%     
==========================================
  Files         423      423              
  Lines       36505    36505              
==========================================
+ Hits        27734    27735       +1     
+ Misses       6833     6832       -1     
  Partials     1938     1938
Impacted Files Coverage Δ
interfaces/builtin/opengl.go 100% <ø> (ø) ⬆️
cmd/snap/cmd_aliases.go 95% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7d79c...7640c6d. Read the comment docs.

@mvo5 mvo5 requested a review from jdstrand September 28, 2017 13:59
@mvo5
Copy link
Contributor

mvo5 commented Sep 28, 2017

Looks good, thank you! We will need a +1 from @jdstrand then this can go in.

Copy link

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@zyga zyga merged commit 6149cd3 into canonical:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants