Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/u2f: add Arculus AuthentiKey #15087

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

tazforky
Copy link
Contributor

Adds Arculus AuthentiKey USB security key device that supports FIDO U2F, CTAP2.1, and PIV.

http://www.linux-usb.org/usb.ids has the 3752:0001 device id as well as https://ccid.apdu.fr/ccid/shouldwork.html#0x37520x0001

Tested webauthn.io register and authenticate with chromium-browser and firefox snaps under a snapcraft built local install and also did ./run-checks.

This is a redo of #15071 which will be closed.

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bboozzoo bboozzoo self-assigned this Feb 14, 2025
@bboozzoo bboozzoo added the Simple 😃 A small PR which can be reviewed quickly label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (a272aac) to head (b467e63).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15087      +/-   ##
==========================================
+ Coverage   78.07%   78.11%   +0.04%     
==========================================
  Files        1182     1172      -10     
  Lines      157743   157665      -78     
==========================================
+ Hits       123154   123157       +3     
+ Misses      26943    26861      -82     
- Partials     7646     7647       +1     
Flag Coverage Δ
unittests 78.11% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Fri Feb 14 17:50:43 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13331664391

Failures:

Preparing:

  • openstack:fedora-41-64:tests/main/snap-run-userdata-current

Executing:

  • google-distro-1:debian-11-64:tests/main/progress
  • openstack:fedora-41-64:tests/main/prepare-image-validation-sets
  • google-core:ubuntu-core-18-64:tests/core/kernel-base-gadget-single-reboot
  • google-core:ubuntu-core-20-64:tests/core/snapd-refresh-vs-services-reboots
  • google:ubuntu-20.04-64:tests/main/lxd:snapd_cgroup_both
  • google:ubuntu-24.10-64:tests/main/try

Restoring:

  • openstack:fedora-41-64:tests/main/refresh-app-awareness:classic
  • openstack:fedora-41-64:tests/main/snap-run-userdata-current
  • openstack:fedora-41-64:tests/main/
  • openstack:fedora-41-64
  • openstack:fedora-41-64:tests/main/prepare-image-validation-sets
  • openstack:fedora-41-64:tests/main/
  • openstack:fedora-41-64
  • openstack:fedora-41-64:tests/main/
  • openstack:fedora-41-64

Copy link
Collaborator

@ernestl ernestl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ernestl
Copy link
Collaborator

ernestl commented Feb 14, 2025

Considering this PR security approved on the basis that it is identical to #15087 that was approved by @alexmurray

@ernestl
Copy link
Collaborator

ernestl commented Feb 14, 2025

Failures do not relate to changes.

@ernestl ernestl merged commit ce3364d into canonical:master Feb 14, 2025
56 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants