Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confdb: process alternative types in order #15067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miguelpires
Copy link
Contributor

@miguelpires miguelpires commented Feb 12, 2025

Allow alternatives to mix ephemeral and non-ephemeral types and process each type in order, taking the first matching alternative's ephemeral tag in consideration when pruning.

@miguelpires miguelpires added the confdb confdb work (previously called registries and before aspects) label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.07%. Comparing base (a272aac) to head (93b4189).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
confdb/schema.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15067   +/-   ##
=======================================
  Coverage   78.07%   78.07%           
=======================================
  Files        1182     1179    -3     
  Lines      157743   157656   -87     
=======================================
- Hits       123154   123089   -65     
+ Misses      26943    26926   -17     
+ Partials     7646     7641    -5     
Flag Coverage Δ
unittests 78.07% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 12, 2025

Fri Feb 14 19:25:32 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13330515354

Failures:

Preparing:

  • openstack:fedora-40-64:tests/main/

Executing:

  • google-distro-1:amazon-linux-2-64:tests/main/progress
  • google-distro-2:arch-linux-64:tests/main/progress
  • openstack:centos-9-64:tests/main/progress
  • openstack:debian-12-64:tests/main/progress
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:regular
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-retry
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:parallel
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-backoff
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:ignore
  • openstack:opensuse-tumbleweed-64:tests/main/snap-refresh-hold
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close_mid_restart
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:restart
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating-from-snap
  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google-core:ubuntu-core-22-64:tests/core/services
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg

Restoring:

  • openstack:debian-12-64:tests/unit/
  • openstack:debian-12-64:tests/unit/
  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google-arm:ubuntu-core-22-arm-64:tests/core/
  • google-arm:ubuntu-core-22-arm-64
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

@miguelpires miguelpires force-pushed the confdb-eph-alternatives branch from c93e72d to 6f6706b Compare February 13, 2025 10:19
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Allow alternatives to mix ephemeral and non-ephemeral types and process
each type in order, taking the first matching alternative's ephemeral
tag in consideration when pruning.

Signed-off-by: Miguel Pires <[email protected]>
@miguelpires miguelpires force-pushed the confdb-eph-alternatives branch from 6f6706b to 93b4189 Compare February 14, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confdb confdb work (previously called registries and before aspects)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants