Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove 'set -x' from "Run spread tests" step in Tests workflow #15062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergiocazzolato
Copy link
Collaborator

We need to remove the 'set -x' because it is including in the output a huge list of tests when doing

spread_list="$($SPREAD -list $RUN_TESTS 2>&1 || true)"

This change is needed because it is including in the output a huge list
of tests when doing

spread_list="$($SPREAD -list $RUN_TESTS 2>&1 || true)"
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@c4ff9e7). Learn more about missing BASE report.
Report is 201 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15062   +/-   ##
=========================================
  Coverage          ?   78.11%           
=========================================
  Files             ?     1177           
  Lines             ?   157300           
  Branches          ?        0           
=========================================
  Hits              ?   122870           
  Misses            ?    26811           
  Partials          ?     7619           
Flag Coverage Δ
unittests 78.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 12, 2025

Wed Feb 12 15:39:18 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13272429104

Failures:

Executing:

  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:restart
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:ignore
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:parallel
  • openstack:opensuse-tumbleweed-64:tests/main/snap-refresh-hold
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close_mid_restart
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:regular
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating-from-snap
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-backoff
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-retry
  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • google-arm:ubuntu-core-22-arm-64:tests/core/services
  • google-core:ubuntu-core-22-64:tests/core/gadget-update-pc
  • google:ubuntu-25.04-64:tests/upgrade/basic
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-22.04-64:tests/main/uc20-create-partitions

Restoring:

  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • google-core:ubuntu-core-22-64:tests/core/gadget-update-pc
  • google-core:ubuntu-core-22-64:tests/core/
  • google-core:ubuntu-core-22-64
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants