Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gadget/install: switch mount flags for ubuntu-save to no{dev,exec,suid} #14740

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

This makes us mount ubuntu-save with no{dev,exec,suid} during install-mode as well

@Meulengracht Meulengracht added the Run nested The PR also runs tests inluded in nested suite label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (96ea7b0) to head (2a57341).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
gadget/install/install.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14740      +/-   ##
==========================================
+ Coverage   78.95%   79.03%   +0.08%     
==========================================
  Files        1084     1087       +3     
  Lines      146638   147689    +1051     
==========================================
+ Hits       115773   116727     +954     
- Misses      23667    23733      +66     
- Partials     7198     7229      +31     
Flag Coverage Δ
unittests 79.03% <72.72%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant