Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlord/install/install.go: use plainkey for save key #14706

Draft
wants to merge 1 commit into
base: fde-manager-features
Choose a base branch
from

Conversation

valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid added Run nested The PR also runs tests inluded in nested suite FDE Manager Pull requests that target FDE manager branch labels Nov 11, 2024
@valentindavid valentindavid force-pushed the valentindavid/save-plainkeys branch 3 times, most recently from 4c3dcd2 to 4bc0793 Compare November 11, 2024 14:26
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 31.18280% with 64 lines in your changes missing coverage. Please review.

Please upload report for BASE (fde-manager-features@bd4c3ff). Learn more about missing BASE report.

Files with missing lines Patch % Lines
overlord/install/install.go 35.71% 18 Missing and 9 partials ⚠️
secboot/keys/plainkey.go 0.00% 14 Missing ⚠️
secboot/keys/plainkey_nosb.go 0.00% 13 Missing ⚠️
boot/makebootable.go 11.11% 8 Missing ⚠️
boot/seal.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             fde-manager-features   #14706   +/-   ##
=======================================================
  Coverage                        ?   78.80%           
=======================================================
  Files                           ?     1095           
  Lines                           ?   147907           
  Branches                        ?        0           
=======================================================
  Hits                            ?   116552           
  Misses                          ?    24070           
  Partials                        ?     7285           
Flag Coverage Δ
unittests 78.80% <31.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FDE Manager Pull requests that target FDE manager branch Run nested The PR also runs tests inluded in nested suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant