tests: replace nfs support test with generalized cifs test #14562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cifs test was created relatively recently to test how a single home directory is mounted using CIFS and how a user using that home directory can use snaps. We had an earlier test for NFS with some more fragile and complex setup.
Given that NFS test fails periodically and it was broken for a while on some systems, replace the old NFS test with a variant of the CIFS test. Most of the existing test is kept intact. The portion that manages the user account is moved to the front to be easily shared with the conditional bits below.
The patch series contains a new toy executable called
okfail
which indicates that a command is allowed to fail without consequences. It should be moved to the test helpers project but it can be done on the next sync.Jira: https://warthogs.atlassian.net/browse/SNAPDENG-31425