tests: show that snap from snapd deb can be bundled #14551
Conversation
zyga
force-pushed
the
feature/test-snap-LD_LIBRARY_PATH-SNAPDENG-32203
branch
from
c266f0f
to
2bf9095
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14551 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.01%
==========================================
Files 1079 1082 +3
Lines 145615 145941 +326
==========================================
+ Hits 114828 115109 +281
- Misses 23601 23635 +34
- Partials 7186 7197 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Developers may want to bundle the snap executable from the snapd project into their application to get access to the snap APIs in a convenient form. This test shows that this can be safely done for as long as the snapd deb is used as the source (not snapd snap) and that the ABI of snapd.deb and the application snap's base match. Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32203 Signed-off-by: Zygmunt Krynicki <[email protected]>
zyga
force-pushed
the
feature/test-snap-LD_LIBRARY_PATH-SNAPDENG-32203
branch
from
2bf9095
to
96ec47f
Compare
|
|
||
|
|
||
| prepare: | | ||
| cp "$(command -v snap)" test-snapd-sh-core24/bin |
There was a problem hiding this comment.
| cp "$(command -v snap)" test-snapd-sh-core24/bin | |
| cp -v "$(command -v snap)" test-snapd-sh-core24/bin |
| # configuration. | ||
| # | ||
| # shellcheck disable=SC2016 | ||
| test-snapd-sh-core24.sh -c 'LD_PRELOAD=/lib/x86_64-linux-gnu/libz.so "$SNAP"/bin/snap' | MATCH 'Usage: snap <command> \[<options>...\]' |
There was a problem hiding this comment.
not sure LD_PRELOAD is making any difference here if it's loading a library from base which matches the running system.
There was a problem hiding this comment.
That's the whole point. It's supposed to show you can do it in a very specific way.
We're not testing for properties of the snap binary from the snapd snap.
There was a problem hiding this comment.
There's nothing specific about it. We almost guarantee that taking a binary from 24.04 it keeps working when executed in a snap that uses core24, preload or not.
|
|
||
|
|
||
| prepare: | | ||
| cp "$(command -v snap)" test-snapd-sh-core24/bin |
There was a problem hiding this comment.
this could also copy the snap command the snapd snap and show that it fails to run
There was a problem hiding this comment.
Yes but then the test name would need to be different. I also don't know what that specific test would show. On some systems (without apparmor) it would actually work because it would load the dynamic linker from /snap/snapd/current
There was a problem hiding this comment.
This test is running only on ubuntu-24.04, which means that if you copy a snap binary from the snap it will fail (or at least should), which is the exact scenario folks should not be doing. i.e. copying stuff from the snapd snap into their snaps.
| # on ubuntu core, because /usr/bin/snap is the "snapd snap" version which is | ||
| # linked differently. | ||
| - ubuntu-24.04-64 | ||
|
|
| @@ -0,0 +1,30 @@ | |||
| summary: snaps bundling /bin/snap from snapd.deb can do so | |||
There was a problem hiding this comment.
Nitpick: Summary should start with capital, and preferable end with '.'
|
Changing milestone to 2.67. It is not important to have merged when cutting the release. |
|
discussed the test with @zyga, he'll push an update. |
|
As per feedback from @zyga, removing from milestone 2.67 in favour of landing layout improvements. |
Developers may want to bundle the snap executable from the snapd project into their application to get access to the snap APIs in a convenient form.
This test shows that this can be safely done for as long as the snapd deb is used as the source (not snapd snap) and that the ABI of snapd.deb and the application snap's base match.
Relates to changes made here: #14509
Jira: https://warthogs.atlassian.net/browse/SNAPDENG-32203