tests/coredump-options: test core dump generation #14549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsosanchezbeato
force-pushed
the
update-coredump-test
branch
from
79abb39
to
57e6ad3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14549 +/- ##
==========================================
+ Coverage 78.85% 78.95% +0.10%
==========================================
Files 1079 1084 +5
Lines 145615 146638 +1023
==========================================
+ Hits 114828 115783 +955
- Misses 23601 23657 +56
- Partials 7186 7198 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alfonsosanchezbeato
force-pushed
the
update-coredump-test
branch
from
57e6ad3
to
f2c6e28
Compare
| else | ||
| BASE=core"$VERSION_ID" | ||
| sed -i "s/##BASE##/$BASE/" core-dump-snap/meta/snap.yaml | ||
| sed -i "s/##BASE##/$BASE/" "$core_dump_d"/meta/snap.yaml |
There was a problem hiding this comment.
is has to be reverted during restore
There was a problem hiding this comment.
Good point, what I've done now is to copy inside the test folder before modifying.
Meulengracht
approved these changes
Oct 14, 2024
The needed changes in the base are now in edge and beta core24 channels: make sure we are generating the core dumps. Also, reuse snap we have used in a similar test in the past.
alfonsosanchezbeato
force-pushed
the
update-coredump-test
branch
from
f2c6e28
to
6436a61
Compare
| else | ||
| BASE=core"$VERSION_ID" | ||
| sed -i "s/##BASE##/$BASE/" core-dump-snap/meta/snap.yaml | ||
| sed -i "s/##BASE##/$BASE/" "$core_dump_d"/meta/snap.yaml |
There was a problem hiding this comment.
Good point, what I've done now is to copy inside the test folder before modifying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The needed changes in the base are now in edge and beta core24 channels: make sure we are generating the core dumps.