Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snap-bootstrap: mount snapd snap directly to /snap #14548

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfonsosanchezbeato
Copy link
Member

On first boot we had to mount the snapd snap to /run/mnt/base. Avoid this duplicate mount by mounting directly to /snapd/snapd/, which will allow also some simplifications in the base script that runs on first boot.

On first boot we had to mount the snapd snap to /run/mnt/base. Avoid
this duplicate mount by mounting directly to /snapd/snapd/<revision>,
which will allow also some simplifications in the base script that
runs on first boot.
@alfonsosanchezbeato
Copy link
Member Author

These changes depend on canonical/core-base#255 , which needs to land first. Furthermore, we would need the base change in core20+ and have all published revisions in stable before this can be released. With this we would make sure that when you create new seeds we would also have the needed base changes so the snap-bootstrap change would not break things.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 67.56757% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ac897ee) to head (60df4c0).
Report is 35 commits behind head on master.

Files with missing lines Patch % Lines
cmd/snap-bootstrap/cmd_initramfs_mounts.go 67.39% 9 Missing and 6 partials ⚠️
cmd/snap-bootstrap/initramfs_systemd_mount.go 67.85% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14548      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.01%     
==========================================
  Files        1079     1080       +1     
  Lines      145615   145903     +288     
==========================================
+ Hits       114828   115074     +246     
- Misses      23601    23630      +29     
- Partials     7186     7199      +13     
Flag Coverage Δ
unittests 78.87% <67.56%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant