cmd/snap/debug-api: option to choose access through /run/snapd-snap.socket #14540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocket Add an option to choose access through the dedicated snap socket. Signed-off-by: Maciej Borzecki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14540 +/- ##
==========================================
+ Coverage 78.85% 79.28% +0.43%
==========================================
Files 1079 1082 +3
Lines 145615 147619 +2004
==========================================
+ Hits 114828 117047 +2219
+ Misses 23601 23381 -220
- Partials 7186 7191 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
approved these changes
Sep 26, 2024
| "header": "Set header (can be repeated multiple times), header kind and value are separated with ': '", | ||
| "request": "HTTP method to use (defaults to GET)", | ||
| "fail": "Fail on request errors", | ||
| "snap-socket": "Use snap access socket", |
There was a problem hiding this comment.
This is vague, can you clarify that this is using the socket used by snapctl when SNAP_NAME is set?
There was a problem hiding this comment.
hm but it's using the snap socket only when --snap-socket is passed in the command line, SNAP_NAME is not checked at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to choose access through the dedicated snap socket. Useful for debugging when curl isn't around.