o/hookstate/ctlcmd, o/fdestate: add efi-secureboot-db-update command, fdestate stubs #14535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
bboozzoo
force-pushed
the
bboozzoo/snapctl-efi-db
branch
2 times, most recently
from
db85056
to
36e203a
Compare
Stubs Signed-off-by: Maciej Borzecki <[email protected]>
Add efi-secureboot-db-update command which hooks into fdestate stubs. Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/snapctl-efi-db
branch
from
d4f521f
to
bbcea1c
Compare
|
Why this? I thought the agreement was to go with a dedicated API endpoint?
…On Thu, 26 Sep 2024 at 11:05, Maciej Borzecki ***@***.***> wrote:
@bboozzoo <https://github.com/bboozzoo> requested your review on: #14535
<#14535> o/hookstate/ctlcmd,
o/fdestate: add efi-secureboot-db-update command, fdestate stubs.
—
Reply to this email directly, view it on GitHub
<#14535 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHOHDKJVCXWYBPT34GIGXTZYPE6PAVCNFSM6AAAAABO2L7BASVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQYTENZSGAZTGMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
The dedicated API endpoint is opened as well, see #14541. I was experimenting with efitools packaged in a snap and figured the snapctl variant may be useful too. Also helped me explore the problem a bit more. Either way I'm fine with keeping or dropping the branch. |
|
we're going forward with a dedicated API error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add efi-secureboot-db-update command which hooks into fdestate stubs.
Related: SNAPDENG-32364