Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snap-bootstrap: XXX: run ps once a second #14534

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zyga
Copy link
Contributor

@zyga zyga commented Sep 25, 2024

We are seeing oom killing snap-bootstrap that takes over a 1.6GB of memory on a 2GB system used in CI. We don't have a theory as to what is going on yet. This patch is not mergable but might help us see what is is happening on the path that leads to failure.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ac897ee) to head (a4f73b6).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
cmd/snap-bootstrap/cmd_initramfs_mounts.go 66.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14534      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.02%     
==========================================
  Files        1079     1079              
  Lines      145615   145735     +120     
==========================================
+ Hits       114828   114952     +124     
+ Misses      23601    23596       -5     
- Partials     7186     7187       +1     
Flag Coverage Δ
unittests 78.87% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We are seeing oom killing snap-bootstrap that takes over a 1.6GB of
memory on a 2GB system used in CI. We don't have a theory as to what is
going on yet. This patch is not mergable but might help us see what is
is happening on the path that leads to failure.

Signed-off-by: Zygmunt Krynicki <[email protected]>
We want to focus on one specific aspect and not waste time and money

Signed-off-by: Zygmunt Krynicki <[email protected]>
This check chokes on the removed ubuntu-daily test that was removed
to focus on core tests with maximum efficiency.

Signed-off-by: Zygmunt Krynicki <[email protected]>
@zyga zyga changed the title cmd/snap-bootstrap: XXX: run ps aux once a second cmd/snap-bootstrap: XXX: run ps once a second Sep 25, 2024
@zyga zyga added the Precious Logs Don't restart tests, the logs are precious label Sep 27, 2024
@bboozzoo
Copy link
Contributor

candidate for closing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Precious Logs Don't restart tests, the logs are precious
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants