Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: consider validation sets when refreshing and installing components #14527

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

andrewphelpsj
Copy link
Member

No description provided.

@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Sep 20, 2024
@andrewphelpsj andrewphelpsj force-pushed the check-vsets-when-installing-comps branch from 661da9b to 0d694db Compare September 24, 2024 19:22
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.15267% with 52 lines in your changes missing coverage. Please review.

Project coverage is 78.89%. Comparing base (ac897ee) to head (fd7ceb5).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
asserts/snapasserts/validation_sets.go 77.27% 15 Missing and 5 partials ⚠️
overlord/snapstate/target.go 87.25% 9 Missing and 4 partials ⚠️
overlord/snapstate/component.go 68.75% 7 Missing and 3 partials ⚠️
overlord/snapstate/snapmgr.go 50.00% 4 Missing and 2 partials ⚠️
overlord/snapstate/storehelpers.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14527      +/-   ##
==========================================
+ Coverage   78.85%   78.89%   +0.03%     
==========================================
  Files        1079     1083       +4     
  Lines      145615   146545     +930     
==========================================
+ Hits       114828   115619     +791     
- Misses      23601    23715     +114     
- Partials     7186     7211      +25     
Flag Coverage Δ
unittests 78.89% <80.15%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewphelpsj andrewphelpsj added this to the 2.67 milestone Sep 25, 2024
@andrewphelpsj andrewphelpsj force-pushed the check-vsets-when-installing-comps branch from 0d694db to fd7ceb5 Compare October 9, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant