o, o/snapstate, tests: on classic auto-install snapd as prereq for non-essential snap install #14173
+369
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
from
342c5aa
to
65fdec5
Compare
ernestl
commented
Jul 12, 2024
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
from
65fdec5
to
4d79b09
Compare
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
4 times, most recently
from
96918bd
to
0612244
Compare
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
from
0612244
to
1515b80
Compare
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
5 times, most recently
from
a6badc6
to
f2e055e
Compare
ernestl
added
the
Needs Samuele review
ernestl
changed the title
ernestl
changed the title
ernestl
changed the title
ernestl
changed the title
ernestl
changed the title
ernestl
changed the title
ernestl
changed the title
bboozzoo
reviewed
Sep 16, 2024
| # Install snaps with snaps with complex interface requirements. | ||
| # Use specific revisions to pin expected behaviour. | ||
| install_snaps() { | ||
| snap install firefox --revision=4848 # 130.0-2 |
There was a problem hiding this comment.
maybe drop firefox? it's large, has many interfaces and for sure will pull in additional content snap dependencies
There was a problem hiding this comment.
Can do, if its ok, will wait a bit to gather more input on what constitutes a solid check for interface "migration".
bboozzoo
approved these changes
Sep 18, 2024
sergiocazzolato
approved these changes
Sep 18, 2024
andrewphelpsj
approved these changes
Sep 18, 2024
ernestl
force-pushed
the
SNAPDENG-24011_enable_classic_with_core_to_install_snapd
branch
from
5bb362b
to
b13af6b
Compare
|
Failures: fedora-os |
nested-ubuntu-24.04 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On classic systems, auto install snapd as prerequisite for any snap that is not os, base, kernel, gadget or snapd.
Previously it was only installed on systems without core, leaving a small amount of systems with snapd deb + core - inconsistent with the majority of systems in terms of re-execution and upgrade path.
The change triggered an explosion of unit test failures. The most efficient approach for addressing this was to install snapd as part of the base test (prevents many breakages) and remove it where required (only a few places).
This mirrors the spread change: #14294
Jira: SNAPDENG-24011
This change overlaps with existing experimental feature: https://github.com/canonical/snapd/blob/master/overlord/snapstate/snapmgr.go#L1167
We should consider deprecating this in a followup.