tests: properly build snapd snap #14141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
added
the
Run nested
github-actions
bot
added
the
Run Nested -auto-
|
Github had a bug, and I had to re-create #13517. |
| snap download --basename=pc-kernel --channel="$CHANNEL/${KERNEL_CHANNEL}" pc-kernel | ||
| unsquashfs -no-progress -d "$UNPACK_DIR" pc-kernel.snap | ||
| snap pack --filename="$TARGET" "$UNPACK_DIR" | ||
| build_snapd_snap() { |
There was a problem hiding this comment.
At some point we should move this to a tool, but it is ok to have it in prepare.sh by now.
| CHANNEL=latest | ||
| else | ||
| CHANNEL=$VERSION | ||
| run_snapcraft() { |
There was a problem hiding this comment.
perhaps the function could receive the path, so then we can use that to build other snaps too.
|
|
||
| local UNPACK_DIR="/tmp/snapd-unpack" | ||
| unsquashfs -no-progress -d "$UNPACK_DIR" snapd_*.snap | ||
| TARGET="${1}" |
There was a problem hiding this comment.
target is defined as local two lines up
Now we build also the test version of snapd snap in `snap-builds` workflow job. We copy this into the spread tests. And we use that snap, which we only instrument instead of copying the snapd deb build. If the snap is not available, then we build it in spread. On CI, this happens on arm since the workflow does not build it. It will also happen when triggering test manually.
…o script scope, use PWD instead of dot notation
Meulengracht
force-pushed
the
valentindavid/with-patchelf-run-tests
branch
from
794b61a
to
6cbcb47
Compare
bboozzoo
approved these changes
Jul 3, 2024
| @@ -9,6 +9,7 @@ set -eux | |||
| # shellcheck source=tests/lib/state.sh | |||
| . "$TESTSLIB/state.sh" | |||
|
|
|||
| : "${WORK_DIR:=/tmp/work-dir}" | |||
sergiocazzolato
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we build also the test version of snapd snap in
snap-buildsworkflow job. We copy this into the spread tests. And we use that snap, which we only instrument instead of copying the snapd deb build.If the snap is not available, then we build it in spread. On CI, this happens on arm since the workflow does not build it. It will also happen when triggering test manually.