cmd,daemon: changes in api data to show components information #14097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if only components are going to be installed.
github-actions
bot
added
the
Needs Documentation -auto-
alfonsosanchezbeato
force-pushed
the
comp-fix-install-messages
branch
from
27afed4
to
b5f9a40
Compare
pedronis
reviewed
Jun 20, 2024
Comment on lines
+353
to
+354
| apiData["components"] = map[string][]string{ | ||
| instanceName: {compInfo.Component.ComponentName}, |
There was a problem hiding this comment.
this is the same format that we use as input in the new APIs right?
There was a problem hiding this comment.
Yes, this is correct
Comment on lines
+353
to
+354
| apiData["components"] = map[string][]string{ | ||
| instanceName: {compInfo.Component.ComponentName}, |
There was a problem hiding this comment.
Yes, this is correct
andrewphelpsj
approved these changes
Jun 21, 2024
cmd/snap/cmd_snap_op.go
Outdated
| // components. | ||
| func (csd *changedSnapsData) changedSnaps() (names []string, notOnlyComps map[string]bool) { | ||
| names = make([]string, 0, len(csd.comps)+len(csd.names)) | ||
| notOnlyComps = map[string]bool{} |
There was a problem hiding this comment.
Suggested change
| notOnlyComps = map[string]bool{} | |
| notOnlyComps = make(map[string]bool, len(csd.names)) |
alfonsosanchezbeato
force-pushed
the
comp-fix-install-messages
branch
from
208d370
to
141f862
Compare
|
Addressed last comments and squashed commits now |
alfonsosanchezbeato
force-pushed
the
comp-fix-install-messages
branch
from
141f862
to
c2fa718
Compare
alfonsosanchezbeato
force-pushed
the
comp-fix-install-messages
branch
from
c2fa718
to
77d03c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to start send and processing components data on installation. With this we can show better messages on installation of a local component.